Re: [PATCH #2] console lock grabbed too early in printk...

From: Russell King (rmk@arm.linux.org.uk)
Date: Tue Jul 04 2000 - 01:19:35 EST


Chris Lattner writes:
> Don't get me wrong, I'm not saying printk is unusable or horrendously
> unstable... I'm just saying that I got bit by it and I'm trying to get a
> fix in so other people don't run into similar things in the future.

There is an easy solution to this - add a comment to printk to indicate
its pointer arguments are kernel-only, or even create a docbook header
for the file.

Then, people will know that they've done something wrong. ;)
   _____
  |_____| ------------------------------------------------- ---+---+-
  | | Russell King rmk@arm.linux.org.uk --- ---
  | | | | http://www.arm.linux.org.uk/~rmk/aboutme.html / / |
  | +-+-+ --- -+-
  / | THE developer of ARM Linux |+| /|\
 / | | | --- |
    +-+-+ ------------------------------------------------- /\\\ |

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:14 EST