Re: foo vs task_struct and kernel timers?

From: Andrew Morton (andrewm@uow.edu.au)
Date: Tue Jul 04 2000 - 10:21:29 EST


Tigran Aivazian wrote:
>
> Hi guys,
>
> I noticed the difference in schedule_timeout() between test1-ac18 (which I
> run) and Linus test3-pre2 (which I read) and Linus' version uses the
> foo_struct to handle the wakeup when the timeout expires - basically, the
> difference is that a call to timer_exit(timer) is made by
> process_timeout().
>
> Anyone understands which way is the correct one? Is the AC version going
> to be migrated into Linus' or not? I.e. should one generally call
> timer_exit() on the timer in the timer's handler function?

In 2.4.0-test3-pre2 timer_exit() was removed completely. So you can now
do a del_timer_sync() on a timer without having to put timer_exit() in
its handler.

However schedule_timeout() still uses del_timer(). This can now be
replaced with del_timer_sync(). I don't know why it hasn't been...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:15 EST