linux-2.2.16/fs/proc/array.c line 483: get_env() why it is not fixed?

• Next message: Oliver Xymoron: "Re: [RFC] solution for the inet_ntoa problem, buffer allocator"
• Previous message: Dale Amon: "Redirected dns packets rejected"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi all

It seems obvious to be:

static int get_env(int pid, char * buffer)
{
        struct task_struct *p;
        int retval;

        read_lock(&tasklist_lock);
        p = find_task_by_pid(pid);

        if (!p || !p->mm) {
                read_unlock(&tasklist_lock);
                return 0;
        }

        retval= get_array(p, p->mm->env_start, p->mm->env_end, buffer);
        read_unlock(&tasklist_lock);
        return retval;
}

The same applies to get_status(), and other functions in the same file...

Am I right?

Is my correction Ok?

Please CC: your reply to uaca@alumni.uv.es

Thanks

        Ulisses

                Debian/GNU Linux: a dream come true
-----------------------------------------------------------------------------
"Computers are useless. They can only give answers." Pablo Picasso

---> Visita http://www.valux.org/ para saber acerca de la <---
---> Asociación Valenciana de Usuarios de Linux <---
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Oliver Xymoron: "Re: [RFC] solution for the inet_ntoa problem, buffer allocator"
• Previous message: Dale Amon: "Redirected dns packets rejected"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:16 EST