Re: [patch-2.4.0-test3-p2] misc fixes.

From: Tigran Aivazian (tigran@veritas.com)
Date: Wed Jul 05 2000 - 13:44:13 EST


On Wed, 5 Jul 2000, Linus Torvalds wrote:

>
>
> On Fri, 30 Jun 2000, Tigran Aivazian wrote:
> >
> > c) documented the fact that for FS_SINGLE filesystems the driver must
> > call kern_mount() after register_filesystem(). This already confused
> > others (e.g. Richard Gooch) so imho it is worth pointing out.
> >
> > d) kern_mount() is supposed to be used only with FS_SINGLE filesystems but
> > the code doesn't enforce it. This patch makes kern_mount() fail with
> > EINVAL on attempt to call it on non-FS_SINGLE filesystems.
>
> Ugh. Would it not be 100% cleaner to just do this automatically for
> FS_SINGLE filesystems upon register/unregister?
>
> Linus

This is exactly what Richard Gooch suggested but Alexander Viro said:

     I don't think so. They are different operations and I'm not too happy
     about mixing them together. Matter of taste, but...

See "FS_SINGLE queries" thread on linux-fsdevel.

Regards,
Tigran

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:17 EST