Richard Gooch wrote:
>
> Philip Langdale writes:
> > Hi all,
> >
> > This is my first ( attempted ) contribution, so try
> > not to laugh too hard. :-)
> >
> > I'm not sure what the 'done thing' is when it comes to implementing
> > devfs support. Some drivers use #ifdef and others rely on the stub
> > functions in the devfs_fs_kernel.h header. I went with the first
> > method as there doesn't seem to be much point iterating through
> > the cpus to do nothing.
>
> It's much better to not have a pile of ugly #ifdef's. I strongly
> recommend ripping them out. That's why I have the stub functions in
> the first place.
>
> For those drivers which do have #ifdef's, it's usually because the
> same driver codebase is maintained for 2.2.x and 2.3.x kernels, and
> 2.2.x doesn't have the header file. I've asked Alan to include the
> header so that drivers don't need these ugly #ifdef's, but he doesn't
> seem to care.
>
The MSR and CPUID drivers are being backported. Furthermore, the amount
of code and data space this adds is quite significant.
-hpa
-- <hpa@transmeta.com> at work, <hpa@zytor.com> in private! "Unix gives you enough rope to shoot yourself in the foot." http://www.zytor.com/~hpa/puzzle.txt- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:18 EST