Hi Linus,
On Fri, 30 Jun 2000, Tigran Aivazian wrote:
> a) small fix to microcode driver - the "cc clobber" directive is not
> needed for cpuid instruction as it doesn't change EFLAGS. Neither it is
> needed in general in asm-i386/processor.h:cpuid() inline (this was
> pointet out by Philipp Rumpf but for some reason didn't appear in
> test3-preX)
is there something wrong about dropping "cc" for cpuid usage? The patch is
still applicable to test3-pre4
Regards,
Tigran
diff -urN -X dontdiff linux/arch/i386/kernel/microcode.c work/arch/i386/kernel/microcode.c
--- linux/arch/i386/kernel/microcode.c Sat Jun 24 12:44:25 2000
+++ work/arch/i386/kernel/microcode.c Fri Jun 30 12:28:20 2000
@@ -11,6 +11,8 @@
*
* http://developer.intel.com/design/pentiumii/manuals/243192.htm
*
+ * For more information, go to http://www.urbanmyth.org/microcode
+ *
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version
@@ -226,7 +228,7 @@
}
wrmsr(0x79, (unsigned int)(m->bits), 0);
- __asm__ __volatile__ ("cpuid" : : : "ax", "bx", "cx", "dx", "cc");
+ __asm__ __volatile__ ("cpuid" : : : "ax", "bx", "cx", "dx");
rdmsr(0x8B, val[0], val[1]);
req->err = 0;
diff -urN -X dontdiff linux/include/asm-i386/processor.h work/include/asm-i386/processor.h
--- linux/include/asm-i386/processor.h Sat Jun 24 12:44:28 2000
+++ work/include/asm-i386/processor.h Fri Jun 30 12:28:58 2000
@@ -144,8 +144,7 @@
"=b" (*ebx),
"=c" (*ecx),
"=d" (*edx)
- : "a" (op)
- : "cc");
+ : "a" (op));
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:18 EST