Re: [patch] alpha compile warnings cleanup

From: Ivan Kokshaysky (ink@jurassic.park.msu.ru)
Date: Fri Jul 07 2000 - 03:25:50 EST


On Thu, Jul 06, 2000 at 10:18:08PM -0700, Richard Henderson wrote:
> > -typedef long __kernel_loff_t;
> > +typedef long long __kernel_loff_t;
>
> Incorrect.

Yes...

> This just means someone forgot to use loff_t
> instead of hardcoding long long.
>
Actually it's a code like this:
        printk("... %Ld ...", offset)
The proper fix is in fs/locks.c

Ivan.

--- 2.4.0t2p4/fs/locks.c Fri Jul 7 12:09:38 2000
+++ linux/fs/locks.c Fri Jul 7 12:12:13 2000
@@ -296,7 +296,8 @@ static void locks_insert_block(struct fi
         if (!list_empty(&waiter->fl_block)) {
                 printk(KERN_ERR "locks_insert_block: removing duplicated lock "
                         "(pid=%d %Ld-%Ld type=%d)\n", waiter->fl_pid,
- waiter->fl_start, waiter->fl_end, waiter->fl_type);
+ (long long)waiter->fl_start, (long long)waiter->fl_end,
+ waiter->fl_type);
                 locks_delete_block(waiter);
         }
         list_add_tail(&waiter->fl_block, &blocker->fl_block);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:20 EST