Hi!
> > It gets the right owner. The socket is owned by root. You are adding
> > a hideous hack. If you must mess with this then it probably makes more sense
> > to think about fchown() semantics on sockets
>
> I've just taken a timeout from my temporary braindamage!
>
> As you say, sock_alloc is not the right place. But I don't
> see any way other than specifically checking if it is a
> local or non-local socket. The attached patch moves it
> into sock_create (and removes some of the other
> braindamage too). It's much nicer (patch attached).
>
> The thing that puzzles me, is that you don't think it's a bug.
> It is of course root that eg. owns an rlogin connection, but
> shouldn't identd and netstat have the possibility of reporting
> the users uid somehow? The identd in particular.
>
> PS: Are you thinking about fchown as something an suid-root
> application should do?
Or maybe rlogin should set fsuid to uid for the part where it is
creating socket?
Pavel
-- I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care." Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Jul 07 2000 - 21:00:21 EST