Re: [patch] drivers/mtd/Config.in

From: David Woodhouse (dwmw2@infradead.org)
Date: Wed Jul 12 2000 - 04:51:00 EST


tigran@veritas.com said:
> not only that, but also what Linus said recently, i.e. "a printk when
> nothing is wrong is a bug" (or something like that). If you look at fs/
> jffs/inode-v23.c:jffs_read_super() it has a couple of imho unnecessary
> printk()

Removing the 'successfully mounted' printk is reasonable - although it's
only on mount and it's within CONFIG_EXPERIMENTAL code so I'd hardly class
it as essential. The other two definitely look like 'something wrong' cases
to me, though. I'll chat with you later.

There is actually a more serious bug fixed in the JFFS code which has
already made it into my tree - but I'm waiting for Al Viro to give me his
verdict and any necessary patches before I offload that onto Linus.

--
dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jul 15 2000 - 21:00:14 EST