"Buggy modules" in test3

From: John Levon (levonj5@cs.man.ac.uk)
Date: Fri Jul 14 2000 - 09:00:00 EST


The patch below is against test3 but haven't been fixed in test4

These are "buggy modules" as mentioned in sys_init_module().
 
There are many more places were "return E.." are used,
but these are in places that don't matter at all like
init()s for register_netdev().

--- drivers/mtd/mtdblock.c Tue Jul 11 19:33:59 2000
+++ drivers/mtd/mtdblock.c.new Wed Jul 12 22:11:03 2000
@@ -286,7 +286,7 @@
         if (register_blkdev(MAJOR_NR,DEVICE_NAME,&mtd_fops)) {
                 printk(KERN_NOTICE "Can't allocate major number %d for Memory Technology Devices.\n",
                        MTD_BLOCK_MAJOR);
- return EAGAIN;
+ return -EAGAIN;
         }
         
         /* We fill it in at open() time. */
--- drivers/mtd/mtdchar.c Tue Jul 11 19:33:59 2000
+++ drivers/mtd/mtdchar.c.new Wed Jul 12 22:12:41 2000
@@ -385,7 +385,7 @@
         if (register_chrdev(MTD_CHAR_MAJOR,"mtd",&mtd_fops)) {
                 printk(KERN_NOTICE "Can't allocate major number %d for Memory Technology Devices.\n",
                        MTD_CHAR_MAJOR);
- return EAGAIN;
+ return -EAGAIN;
         }
 
         return 0;
--- drivers/net/stnic.c Mon Jul 10 03:21:06 2000
+++ drivers/net/stnic.c.new Wed Jul 12 22:14:22 2000
@@ -130,7 +130,7 @@
       printk (" unable to get IRQ %d.\n", dev->irq);
       kfree(dev->priv);
       dev->priv = NULL;
- return EAGAIN;
+ return -EAGAIN;
     }
 
   ei_status.name = "eth0";

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jul 15 2000 - 21:00:19 EST