On Fri, 21 Jul 2000, Andre Hedrick wrote:
> With out the full touch it will not work.
> 20% are functionally that have to be there for 2.4 to stand a chance of
> being correct.
Ok, separate out those parts and submit them on their own. I read your
patch and I figured that some percentage was clearly unrelated.
> 80% is TASKFILE rewrite to give us the armor.
That means still 50k and that's way too large a rewrite to be
considered a bugfix. I think something like the below can do it in less
than 10 lines for 2.4 and might even pass the "obviously correct"
criterion. Save the command parser business for 2.5.
> > case HDIO_DRIVE_CMD:
> > .
> > .
> > .
> > int i, raw_cmds[]={WIN_WRITE, WIN_WRITEDMA, ...,0};
> > for(i=0; raw_cmds[i]; i++)
> > if(cmd==raw_cmds[i] && !capable(CAP_SYS_RAW))
> > return -EACCESS;
-- "Love the dolphins," she advised him. "Write by W.A.S.T.E.."- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sun Jul 23 2000 - 21:00:17 EST