RE: Re: [PATCH] removal of unnecessary irq save/restore in tasklet_hi_schedule

From: Linus Torvalds (torvalds@transmeta.com)
Date: Tue Aug 01 2000 - 16:54:16 EST


On Mon, 31 Jul 2000 pavel-velo@bug.ucw.cz wrote:
>
> >That said, SA_INTERRUPT still works, but it's really only meant to be used
> >for the timer handler (you don't want the timer to be interruptible: it's
> >fast, and at least the SCSI layer historically wanted the timer to tick
> >_while_ a SCSI interrupt is active, so you must not have a SCSI interrupt
> >interrupt the timer, because if that happens..)
>
> I think this ScsI uglyness is gone these days... I converted seagate.c
> to use delay loops because now SCSI calls driver with interrupts
> disabled...

You're probably right: some of the SCSI stuff was cleaned up in order to
make room for the io_request_lock etc, and that didn't allow some of the
uglier things people had done in the past.

However, for now we'll just leave SA_INTERRUPT deprecated and hopefully
make people aware of the fact that they shouldn't play with it.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Aug 07 2000 - 21:00:07 EST