Re: test6pre1 change for sysrq config-option

From: Arjan van de Ven (adve@oce.nl)
Date: Thu Aug 03 2000 - 08:03:02 EST


In article <Pine.GSO.4.21.0008031424400.29312-100000@khan.acc.umu.se> you wrote:
> --- v2.4.0-test5/linux/arch/i386/config.in Fri Jul 14 12:12:05 2000
> +++ linux/arch/i386/config.in Mon Jul 31 10:23:43 2000
> @@ -344,5 +344,5 @@
> comment 'Kernel hacking'

> #bool 'Debug kmalloc/kfree' CONFIG_DEBUG_MALLOC
> -bool 'Magic SysRq key' CONFIG_MAGIC_SYSRQ
> +dep_bool 'Magic SysRq key' CONFIG_MAGIC_SYSRQ $CONFIG_VT
> endmenu

> In my opinion, this patch is incorrect, as SysRq should, at least
> supposedly, work with serial consoles as well, by issuing a break.

Maybe you are right in theory. There are 3 things that make theory different
from practice right now:

1) Serial sysrq is reported no to work for 2.4 kernels.
2) You cannot compile a 2.4-test kernel without CONFIG_VT but with
   CONFIG_MAGIC_SYSRQ right now; the dep_bool change is just making
   this explicit.
3) Even 2.2.16 doesn't seem to contain code for Serial sysrq

Please, fix the first two issues before removing the "dep_"....

Greetings,
   Arjan van de Ven

Greetings,
   Arjan van de Ven

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Aug 07 2000 - 21:00:10 EST