Re: [PATCH] Configure bug

From: Andrzej Krzysztofowicz (ankry@pg.gda.pl)
Date: Thu Aug 03 2000 - 11:02:55 EST


I think, same patch should be applied to 2.2.
Alan ?

John Levon wrote:
>
> Running make oldconfig on test5 :
>
> Default NLS Option (CONFIG_NLS_DEFAULT) [iso8859-1] (NEW) ?
>
> .config excerpt :
> CONFIG_NLS_DEFAULT="?"
>
> patch against test5 to fix this, tested with make config, make oldconfig
> Of course this is broken if anything actually has "?" as a valid input ?

--- scripts/Configure.old Wed Aug 2 20:49:41 2000
+++ scripts/Configure Wed Aug 2 20:52:25 2000
@@ -419,7 +419,14 @@
 function string () {
         old=$(eval echo "\${$2}")
         def=${old:-$3}
- readln "$1 ($2) [$def] " "$def" "$old"
+ while :; do
+ readln "$1 ($2) [$def] " "$def" "$old"
+ if [ "$ans" = "?" ]; then
+ help "$2"
+ else
+ break
+ fi
+ done
         define_string "$2" "$ans"
}
 #
--- Documentation/kbuild/config-language.txt.old Wed Aug 2 20:59:31 2000
+++ Documentation/kbuild/config-language.txt Wed Aug 2 21:01:43 2000
@@ -291,6 +291,7 @@
 This verb displays /prompt/ to the user, accepts a value from the user,
 and assigns that value to /symbol/. /word/ is the default value. Legal
 input values are any ASCII string, except for the characters '"' and '\\'.
+Configure will trap an input string of "?" to display help.
 
 The default value is mandatory.
 

--
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Aug 07 2000 - 21:00:11 EST