Re: Bad SMP race in getblk()

From: Andrea Arcangeli (andrea@suse.de)
Date: Thu Aug 03 2000 - 19:19:10 EST


On Thu, 3 Aug 2000, Linus Torvalds wrote:

>It looks pretty, but it seems to deadlock somewhere. Probably something
>that gets called with the lock held and re-gets the lock..

Woops, sorry about that. This incrmental patch should fix it (going to
test it now).

--- 2.4.0-test5/fs/buffer.c.~2~ Fri Aug 4 02:13:14 2000
+++ 2.4.0-test5/fs/buffer.c Fri Aug 4 02:17:05 2000
@@ -849,8 +849,6 @@
         write_unlock(&hash_table_lock);
         spin_unlock(&lru_list_lock);
         refill_freelist(size);
- spin_lock(&lru_list_lock);
- write_lock(&hash_table_lock);
         goto repeat;
 }
 

Andrea

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Mon Aug 07 2000 - 21:00:12 EST