Re: [patch] 2.4.0-test6-pre8: Magic SysRq fixes for serial.c

From: Philipp Rumpf (prumpf@parcelfarce.linux.theplanet.co.uk)
Date: Wed Aug 09 2000 - 05:52:42 EST


On Wed, Aug 09, 2000 at 11:48:45AM +0200, Maciej W. Rozycki wrote:
> It appears that someone else's fixes for magic SysRq went into
> 2.4.0-test6-pre*. That's obviously fine, but one hunk of my patch I've
> sent you recently should still be applied. Without the hunk, the 8250
> serial console driver still ignores the setting of sysrq_enabled and works
> as if it was enabled all the time.

That's just not true. handle_sysrq now exits without action if
sysrq_enabled == 0. In fact the only reason it's a global variable is
because sysctl requires it - hopefully that will be fixed in 2.5 (ELF
section based sysctl).

> Following is the hunk extracted from my patch. It applies cleanly.

But it doesn't compile, does it ? (there should be no visible definition
for sysrq_enabled in serial.c)

        Philipp Rumpf

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:18 EST