Re: DVD capacity bug for IDE CD's in linux-2.4.0-test6

From: Jens Axboe (axboe@suse.de)
Date: Mon Aug 14 2000 - 18:09:46 EST


On Tue, Aug 15 2000, Andries Brouwer wrote:
> > Prior to linux-2.4.0-test2, the call to cdrom_get_last_written
> > had been commented out.
>
> Ah - I may have been responsible for removing the `#if 0',
> see the linux-kernel post of 9 Jun 2000 with subject `[PATCH] cdrom stuff'.
> In my patch I had
>
> + if (!CDROM_CAN(CDC_CD_R | CDC_CD_RW))
> goto use_toc;
>
> but the current kernel code has (in cdrom_get_last_written())
>
> if (!CDROM_CAN(CDC_CD_R | CDC_CD_RW | CDC_DVD_R | CDC_DVD_RAM))
> goto use_toc;
>
> Do things improve if you go back to my version?

That should actually read if (drives_capable && !dvd_media), but I guess
using it on CD-R/W as you original put in there is the better solution
for now (since we don't track media yet).

-- 
* Jens Axboe <axboe@suse.de>
* SuSE Labs

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Aug 15 2000 - 21:00:35 EST