Re: [PATCH] Re: Move of input drivers, some word needed from you

From: Linus Torvalds (torvalds@transmeta.com)
Date: Mon Aug 21 2000 - 13:45:12 EST


On Mon, 21 Aug 2000, Christoph Hellwig wrote:
>
> It could be done. But having related drivers in one place is the
> cleaner solution (IMHO).

Indeed.

Which is why I want all the USB drivers in one place.

The USB interfaces are more likely to change than the keyboard interfaces.
When somebody changes how the USB urb's interact, I'd rather have all of
that under one tree.

Think about it another way: what about a driver that implements a
touchscreen and a framebuffer device, all in one (imagine a graphics chip
with built-in touch-screen support)? Do you want to split it up, so that
the touchscreen part is in "input", and the framebuffer part is in video?
Imagine the nastyness when these "two" drivers have to synchronize over
shared resources? (This, btw, is how the PC keyboard + PS/2 mouse driver
worked. Nightmare with shared spinlocks etc).

No. You don't split it up according to function. You split it up according
to other issues first, and _then_ you may sub-split it according to
function.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Aug 23 2000 - 21:00:05 EST