RE: [patch] scheduler bugfix, SMP, 2.4.0-test7

From: Dimitris Michailidis (dimitris@cthulhu.engr.sgi.com)
Date: Mon Aug 28 2000 - 17:09:20 EST

Next message: Matthew Dharm: "Re: mount misbehaves in 2.4.0-test6 and test7"
Previous message: Arnaldo Carvalho de Melo: "[PATCH] cpqarray: bugfixes & cleanups"
In reply to: Ingo Molnar: "[patch] scheduler bugfix, SMP, 2.4.0-test7"
Next in thread: Linus Torvalds: "RE: [patch] scheduler bugfix, SMP, 2.4.0-test7"
Reply: Linus Torvalds: "RE: [patch] scheduler bugfix, SMP, 2.4.0-test7"
Reply: Ingo Molnar: "RE: [patch] scheduler bugfix, SMP, 2.4.0-test7"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 28-Aug-2000 Ingo Molnar wrote:

> the attached sched-2.4.0-test7-C1 patch fixes a 'missed wakeup'
> SMP-scheduler bug.

+running_again:
+ if (prev == idle_task(smp_processor_id()))
+ goto out_unlock;

Why don't you move the test for the idle task to the beginning of the
function so we don't need to take the run queue lock if prev is idle? There
is nothing to be done for idle tasks, we don't even need to set ->has_cpu.

-- 
Dimitris Michailidis                    dimitris@engr.sgi.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Matthew Dharm: "Re: mount misbehaves in 2.4.0-test6 and test7"
Previous message: Arnaldo Carvalho de Melo: "[PATCH] cpqarray: bugfixes & cleanups"
In reply to: Ingo Molnar: "[patch] scheduler bugfix, SMP, 2.4.0-test7"
Next in thread: Linus Torvalds: "RE: [patch] scheduler bugfix, SMP, 2.4.0-test7"
Reply: Linus Torvalds: "RE: [patch] scheduler bugfix, SMP, 2.4.0-test7"
Reply: Ingo Molnar: "RE: [patch] scheduler bugfix, SMP, 2.4.0-test7"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:22 EST