Re: [PATCH] mtrr: s/suser/capable/

From: Matthew Kirkwood (matthew@hairy.beasts.org)
Date: Thu Aug 31 2000 - 05:27:17 EST

Next message: Paul Gortmaker: "Re: [PATCH] 2.2: /proc/config.gz"
Previous message: Michael Bielicki: "/proc/sys/kernel/shmmax does not increase shared ram"
In reply to: Arnaldo Carvalho de Melo: "[PATCH] mtrr: s/suser/capable/"
Next in thread: Andi Kleen: "Re: [PATCH] mtrr: s/suser/capable/"
Reply: Andi Kleen: "Re: [PATCH] mtrr: s/suser/capable/"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, 30 Aug 2000, Arnaldo Carvalho de Melo wrote:

> Please consider applying.

And then please don't apply.

> case MTRRIOC_ADD_ENTRY:
> - if ( !suser () ) return -EPERM;
> + if ( !capable(CAP_SYS_ADMIN) ) return -EPERM;

Please think further about these random changes. CAP_SYS_ADMIN
is already bloated with useless junk and these aren't helping
the situation.

These cases in mtrr.c are clearly CAP_SYS_RAWIO.

Matthew.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Paul Gortmaker: "Re: [PATCH] 2.2: /proc/config.gz"
Previous message: Michael Bielicki: "/proc/sys/kernel/shmmax does not increase shared ram"
In reply to: Arnaldo Carvalho de Melo: "[PATCH] mtrr: s/suser/capable/"
Next in thread: Andi Kleen: "Re: [PATCH] mtrr: s/suser/capable/"
Reply: Andi Kleen: "Re: [PATCH] mtrr: s/suser/capable/"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:26 EST