[patch] Compile warnings in drivers/scsi/advansys.c (240t8p1)

From: Rasmus Andersen (rasmus@jaquet.dk)
Date: Thu Aug 31 2000 - 13:34:03 EST


Hi.

When I compile drivers/scsi/advansys.c without procfs support I get the
following warnings:

drivers/scsi/advansys.c:9872: warning: `asc_proc_copy' defined but not used
drivers/scsi/advansys.c:8746: warning: `asc_prt_board_devices' defined but not used
drivers/scsi/advansys.c:8787: warning: `asc_prt_adv_bios' defined but not used
drivers/scsi/advansys.c:8954: warning: `asc_prt_asc_board_eeprom' defined but not used
drivers/scsi/advansys.c:9079: warning: `asc_prt_adv_board_eeprom' defined but not used
drivers/scsi/advansys.c:9348: warning: `asc_prt_driver_conf' defined but not used
drivers/scsi/advansys.c:9447: warning: `asc_prt_asc_board_info' defined but not used
drivers/scsi/advansys.c:9632: warning: `asc_prt_adv_board_info' defined but not used
drivers/scsi/advansys.c:10338: warning: `asc_prt_board_stats' defined but not used

The following patch fixes this. Please commment:

--- linux-240test6-clean/drivers/scsi/advansys.c Mon Jul 31 21:03:17 2000
+++ linux/drivers/scsi/advansys.c Sat Aug 12 21:22:42 2000
@@ -4113,9 +4113,9 @@
  * advansys.h contains function prototypes for functions global to Linux.
  */
 
-#if LINUX_VERSION_CODE >= ASC_LINUX_VERSION(1,3,0)
+#if (LINUX_VERSION_CODE >= ASC_LINUX_VERSION(1,3,0)) && defined(CONFIG_PROC_FS)
 STATIC int asc_proc_copy(off_t, off_t, char *, int , char *, int);
-#endif /* version >= v1.3.0 */
+#endif /* version >= v1.3.0 && CONFIG_PROC_FS*/
 #if LINUX_VERSION_CODE < ASC_LINUX_VERSION(1,3,70)
 STATIC void advansys_interrupt(int, struct pt_regs *);
 #else /* version >= v1.3.70 */
@@ -4151,7 +4151,7 @@
 STATIC int asc_rmqueue(asc_queue_t *, REQP);
 STATIC int asc_isqueued(asc_queue_t *, REQP);
 STATIC void asc_execute_queue(asc_queue_t *);
-#if LINUX_VERSION_CODE >= ASC_LINUX_VERSION(1,3,0)
+#if (LINUX_VERSION_CODE >= ASC_LINUX_VERSION(1,3,0)) && defined(CONFIG_PROC_FS)
 STATIC int asc_prt_board_devices(struct Scsi_Host *, char *, int);
 STATIC int asc_prt_adv_bios(struct Scsi_Host *, char *, int);
 STATIC int asc_get_eeprom_string(ushort *serialnum, uchar *cp);
@@ -4161,15 +4161,15 @@
 STATIC int asc_prt_asc_board_info(struct Scsi_Host *, char *, int);
 STATIC int asc_prt_adv_board_info(struct Scsi_Host *, char *, int);
 STATIC int asc_prt_line(char *, int, char *fmt, ...);
-#endif /* version >= v1.3.0 */
+#endif /* version >= v1.3.0 && CONFIG_PROC_FS*/
 
 /* Declaration for Asc Library internal functions referenced by driver. */
 STATIC int AscFindSignature(PortAddr);
 STATIC ushort AscGetEEPConfig(PortAddr, ASCEEP_CONFIG *, ushort);
 
-#ifdef ADVANSYS_STATS
+#if defined(ADVANSYS_STATS) && defined(CONFIG_PROC_FS)
 STATIC int asc_prt_board_stats(struct Scsi_Host *, char *, int);
-#endif /* ADVANSYS_STATS */
+#endif /* ADVANSYS_STATS && CONFIG_PROC_FS*/
 
 #ifdef ADVANSYS_DEBUG
 STATIC void asc_prt_scsi_host(struct Scsi_Host *);
@@ -8729,7 +8729,7 @@
     return;
 }
 
-#if LINUX_VERSION_CODE >= ASC_LINUX_VERSION(1,3,0)
+#if (LINUX_VERSION_CODE >= ASC_LINUX_VERSION(1,3,0)) && defined(CONFIG_PROC_FS)
 /*
  * asc_prt_board_devices()
  *
@@ -9923,7 +9923,7 @@
     va_end(args);
     return ret;
 }
-#endif /* version >= v1.3.0 */
+#endif /* version >= v1.3.0 && CONFIG_PROC_FS*/
 
 
 /*
@@ -10323,7 +10323,7 @@
  * --- Tracing and Debugging Functions
  */
 
-#ifdef ADVANSYS_STATS
+#if defined(ADVANSYS_STATS) && defined(CONFIG_PROC_FS)
 /*
  * asc_prt_board_stats()
  *
@@ -10482,7 +10482,7 @@
 
      return totlen;
 }
-#endif /* ADVANSYS_STATS */
+#endif /* ADVANSYS_STATS && CONFIG_PROC_FS*/
 
 #ifdef ADVANSYS_DEBUG
 /*

-- 
Regards,
        Rasmus(rasmus@jaquet.dk)

"I have a nice perspective on what it means to be in charge of the most important project in the history of mankind." --Brian Valentine, W2k Proj Mgr - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 21:00:28 EST