Re: [patchlet] Removing unneeded line in vmtruncate() (2.4.0-t8p1)

From: Alexander Viro (
Date: Sat Sep 02 2000 - 01:07:41 EST

On Fri, 1 Sep 2000, Tigran Aivazian wrote:

> Rasmus, you introduced a bug because you removed the code but left the
> comment around. now /* this should go into ->truncate */ is there and very
> confusing - what should go into ->truncate?

... except that comment is there for purpose. Expanding ->truncate()
should not set ->i_size until it's done with the metadata. You don't want
mappings on the part currently being expanded. It doesn't matter for ext2
and friends, but it's a problem for FAT and friends.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Please read the FAQ at

This archive was generated by hypermail 2b29 : Thu Sep 07 2000 - 21:00:12 EST