Re: [PATCH] arch/i386/kernel/acpi.c: get rid of check_region and other small fixes/cleanups

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sat Sep 16 2000 - 21:49:08 EST

Next message: Dunlap, Randy: "RE: system hang with usb audio driver"
Previous message: Matthew Dharm: "Re: [BUG] That bloody /usr/local busy back again"
Next in thread: Arnaldo Carvalho de Melo: "Re: [PATCH] arch/i386/kernel/acpi.c: get rid of check_region and other small fixes/cleanups"
Reply: Arnaldo Carvalho de Melo: "Re: [PATCH] arch/i386/kernel/acpi.c: get rid of check_region and other small fixes/cleanups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Applied, but... :)

In reviewing your patch, I noticed more ugliness. Can you be convinced
to take care of these, too?

In acpi_init(), it is possible for the function to error exit without
cleaning up from a successful acpi_claim_ioports call.

Further, acpi_claim_ioports itself is pretty nasty if some of its
acpi_claim calls succeed, and others fail.

We're getting there..

Jeff

-- 
Jeff Garzik              | Would you *really* want to
Building 1024            | get on a non-stop flight?
MandrakeSoft, Inc.       |       -- George Carlin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Dunlap, Randy: "RE: system hang with usb audio driver"
Previous message: Matthew Dharm: "Re: [BUG] That bloody /usr/local busy back again"
Next in thread: Arnaldo Carvalho de Melo: "Re: [PATCH] arch/i386/kernel/acpi.c: get rid of check_region and other small fixes/cleanups"
Reply: Arnaldo Carvalho de Melo: "Re: [PATCH] arch/i386/kernel/acpi.c: get rid of check_region and other small fixes/cleanups"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 21:00:14 EST