net/sunrpc/clnt.c: erroneous fallthru

• Next message: Rusty Russell: "Re: Question: Using floating point in the kernel"
• Previous message: Mark James: "Re: Function calls not permitted in kernel code"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

There is a missing case break in net/sunrpc/clnt.c that causes the kernel
to print an extra, spurious message when a Sun RPC (NFS) request is rejected
by a server with the error RPC_AUTH_TOOWEAK. The missing break also causes
EIO to be returned to the user process instead of EACCES, which seems wrong
too. I noticed this bug in kernel 2.2.14, but I checked and it's still in
2.4.0-test8, so the patch is still needed. Here it is.

--- /usr/src/linux-2.2.14/net/sunrpc/clnt.c Tue Jan 4 10:12:27 2000
+++ /tmp/clnt.c Wed Sep 20 16:42:33 2000
@@ -784,6 +784,7 @@
                 case RPC_AUTH_TOOWEAK:
                         printk("call_verify: server requires stronger "
                                "authentication.\n");
+ break;
                 default:
                         printk("call_verify: unknown auth error: %x\n", n);
                         error = -EIO;

--
Tim Mann  tim.mann@compaq.com  http://www.tim-mann.org
Compaq Computer Corporation, Systems Research Center, Palo Alto, CA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Rusty Russell: "Re: Question: Using floating point in the kernel"
• Previous message: Mark James: "Re: Function calls not permitted in kernel code"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Sep 23 2000 - 21:00:24 EST