John Levon <levonj5@cs.man.ac.uk> writes:
>
>The following drivers appear to set TASK_RUNNING needlessly.
>Against test8pre1.
...
>--- drivers/char/dtlk.c Sat Jul 15 21:11:47 2000
>+++ drivers/char/dtlk.c.new Fri Sep 1 04:24:48 2000
>@@ -392,7 +392,6 @@
> {
> current->state = TASK_INTERRUPTIBLE;
> schedule_timeout((ms * HZ + 1000 - HZ) / 1000);
>- current->state = TASK_RUNNING;
> }
>
> static int dtlk_readable(void)
>--- drivers/char/synclink.c Wed Aug 2 20:38:26 2000
>+++ drivers/char/synclink.c.new Fri Sep 1 04:26:26 2000
>@@ -3354,7 +3354,6 @@
> }
> }
>
>- set_current_state(TASK_RUNNING);
> exit:
> if (debug_level >= DEBUG_LEVEL_INFO)
> printk("%s(%d):mgsl_wait_until_sent(%s) exit\n",
I just copied what some of the other drivers had. If it is not
needed, then taking it out is fine with me.
- Jim Van Zandt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Sep 30 2000 - 21:00:13 EST