Re: 3c985 (aka acenic) gigabit support broken in test9pre7?

From: Andrew Morton (andrewm@uow.edu.au)
Date: Thu Sep 28 2000 - 06:52:38 EST


Jes Sorensen wrote:
>
> >>>>> "Olivier" == Olivier Galibert <galibert@pobox.com> writes:
>
> Olivier> I compiled in the support for the 3c985, but, somehow, the
> Olivier> kernel does not seem to see the card.
>
> Olivier> Dual p3, asus p2b-d motherboard, test9pre7+reiserfs.
>
> Are you sure the drivers/net/acenic.o file got compiled and linked
> into the kernel? You are compiling everything statically which is a
> problem on the x86 in particular when using the acenic driver as it
> has a fairly large firmware image attached. Try compiling it as a
> loadable module.

The module_init() and module_exit() are inside `#ifdef MODULE'. So if
the driver is statically linked it doesn't register any initcalls. It
won't do anything.

--- linux-2.4.0-test9-pre7/drivers/net/acenic.c Tue Sep 26 21:45:30 2000
+++ linux-akpm/drivers/net/acenic.c Thu Sep 28 22:50:13 2000
@@ -733,7 +733,6 @@
 }
 
 
-#ifdef MODULE
 #if (LINUX_VERSION_CODE < 0x02032a)
 int init_module(void)
 {
@@ -748,7 +747,6 @@
 #else
 module_init(ace_module_init);
 module_exit(ace_module_cleanup);
-#endif
 #endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 30 2000 - 21:00:21 EST