Re: [PATCH] 2.2.x Isdn init function fix

From: Paul Slootman (paul@murphy.nl)
Date: Fri Sep 29 2000 - 03:19:51 EST

Next message: Alan Cox: "Re: reading 1 hardsector size, not one block size"
Previous message: Lars Gaarden: "Re: Promise PDC20295 support?"
In reply to: Luca Montecchiani: "[PATCH] 2.2.x Isdn init function fix"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu 28 Sep 2000, Luca Montecchiani wrote:

> Init function for hisax driver cause a kernel hangup if the
> idstring was omitted

Good catch.

> - if (strlen(str)) {
> + if (str) {

I'd make this:

+ if (str && *str) {

to preserve the intention of the original code
(the string mustn't be empty).

> - if (strlen(str)) {
> + if (str) {

ditto

Paul Slootman

-- 
home:       paul@wurtel.demon.nl http://www.wurtel.demon.nl/
work:       paul@murphy.nl       http://www.murphy.nl/
debian:     paul@debian.org      http://www.debian.org/
isdn4linux: paul@isdn4linux.de   http://www.isdn4linux.de/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Alan Cox: "Re: reading 1 hardsector size, not one block size"
Previous message: Lars Gaarden: "Re: Promise PDC20295 support?"
In reply to: Luca Montecchiani: "[PATCH] 2.2.x Isdn init function fix"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Sep 30 2000 - 21:00:24 EST