Re: [PATCH] esssolo1.c: get rid of check_region

From: Jeff Garzik (jgarzik@mandrakesoft.mandrakesoft.com)
Date: Fri Sep 29 2000 - 04:08:46 EST


On Fri, 29 Sep 2000, Alan Cox wrote:
> > Thomas, is there a reason for having the OPL3 region check in the
> > xxx_open syscall?

> The opl3 driver might not have been loaded at init time.

esssolo1 does its own FM, so the code in question is attempting to let
the driver support either external opl3 driver, or internal,
more-functional FM.

In solo1_probe, an FM interface is registered.

So, IMHO there is a bug somewhere... Why register an FM interface in
probe, and then check_region for another FM driver in _open? Is this
intentional or really a bug?

        Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Sep 30 2000 - 21:00:24 EST