Re: [PATCH] 2.2.18pre13: USB tweak for VAIO

From: Johannes Erdfelt (johannes@erdfelt.com)
Date: Mon Oct 02 2000 - 16:23:26 EST


On Mon, Oct 02, 2000, Chip Salzenberg <chip@valinux.com> wrote:
> Patch: usbdock-1
> From: Geoff Harrison <mandrake@valinux.com>
>
> Allow short report frames via USB ... apparently they are normal for
> some Sony VAIOs when docked.

This is actually a hack to get a specific PS/2 to USB device to work.
The reports that get sent back are short by one byte which doesn't seem
to cause problems, but apparentely are illegal per the spec.

The cause and real fix are still under investigation.

> Index: linux/drivers/usb/hid.c
> diff -u linux/drivers/usb/hid.c:1.2 linux/drivers/usb/hid.c:1.2.2.1
> --- linux/drivers/usb/hid.c:1.2 Wed Sep 27 23:44:24 2000
> +++ linux/drivers/usb/hid.c Thu Sep 28 11:51:32 2000
> @@ -1096,10 +1096,12 @@
> return;
> }
>
> +#if 0
> if (len < ((report->size - 1) >> 3) + 1) {
> dbg("report %d is too short, (%d < %d)", report->id, len, ((report->size - 1) >> 3) + 1);
> return;
> }
> +#endif
>
> for (n = 0; n < report->maxfield; n++)
> hid_input_field(device, report->field[n], data);

JE

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Oct 07 2000 - 21:00:10 EST