2.4.0test9pre9 - is it correct ?

• Next message: Tom Sightler: "Xircom problems with test9-preX"
• Previous message: Petko Manolov: "Re: Request for net guru help: waitqueue oops"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,
   I noticed the following change in the test9pre9 and doubt if it is
correct. Especially as Alan Cox rejected *identical* change for 2.2
arguing that in may break some architectures with non-byte based memory
addressing (especially ARM).

diff -uNr linux-test9pre8/drivers/net/3c505.c linux-test9pre9/drivers/net/3c505.c
--- linux-test9pre8/drivers/net/3c505.c Mon Oct 2 20:30:53 2000
+++ linux-test9pre9/drivers/net/3c505.c Tue Oct 3 15:35:22 2000
@@ -130,15 +130,15 @@
 #define INVALID_PCB_MSG(len) \
         printk(invalid_pcb_msg, (len),filename,__FUNCTION__,__LINE__)
 
-static char *search_msg __initdata = "%s: Looking for 3c505 adapter at address %#x...";
+static char search_msg[] __initdata = "%s: Looking for 3c505 adapter at address %#x...";
 
-static char *stilllooking_msg __initdata = "still looking...";
+static char stilllooking_msg[] __initdata = "still looking...";
[...]

Could anybody confirm whether the above patch is correct or errorneus ?

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Tom Sightler: "Xircom problems with test9-preX"
• Previous message: Petko Manolov: "Re: Request for net guru help: waitqueue oops"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Oct 07 2000 - 21:00:12 EST