Re: [PATCH] console palette fix

From: James Simmons (jsimmons@suse.com)
Date: Sat Oct 07 2000 - 02:32:43 EST


> Although this patch is correct, and was accepted in 2.4.*, it creates a
> secondary problem after applying it - A dark textmode console for some
> cards, unrelated to the frame buffer mode. An *additional* patch is needed
> in order to fix it:

Yes their was this problem with a earlier patch but I was under the
impression that the most recent patch (below) fixed this problem. Do you
know which cards have this problem? I like to get a list of them to see
what could be causing the problem. I believe it is a X server problem. My
theory is that the problem occurs for video cards whose X servers use the
gamma ramp. I personally have never seen this problem but if you can tell
which cards specifically I can get that card and track down the problem.
Has your patch been tested with all the cards avaliable with this problem?

> --- linux-2.2.17/drivers/char/console.c Mon Sep 4 15:39:17 2000
> +++ linux.vanilla/drivers/char/console.c Thu Oct 5 15:17:00 2000
> @@ -2569,6 +2569,7 @@
> console_blanked = 0;
> if (console_blank_hook)
> console_blank_hook(0);
> + set_palette(currcons);
> if (sw->con_blank(vc_cons[currcons].d, 0))
> /* Low-level driver cannot restore -> do it ourselves */
> update_screen(fg_console);
>
>
>
> > Here is patch to fix console palettes for the 2.2.X kernels. Its against
> > 2.2.17.
> >
> > --- console.c.orig Wed Oct 4 22:23:34 2000
> > +++ console.c Wed Oct 4 22:28:50 2000
> > @@ -575,10 +575,13 @@
> > }
> >
> > if (redraw) {
> > + int update;
> > +
> > set_origin(currcons);
> > + update = sw->con_switch(vc_cons[currcons].d);
> > set_palette(currcons);
> > - if (sw->con_switch(vc_cons[currcons].d) && vcmode != KD_GRAPHICS)
> > - /* Update the screen contents */
> > + if (update && vcmode != KD_GRAPHICS)
> > + /* Update the screen contents */
> > do_update_region(currcons, origin, screenbuf_size/2);
> > }
> > set_cursor(currcons);
> >
>
> --
> Dan Aloni
> dax@karrde.org
>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Oct 07 2000 - 21:00:20 EST