Re: [PATCH] drivers/usb/Config.in

From: Vojtech Pavlik (vojtech@suse.cz)
Date: Tue Oct 10 2000 - 02:34:33 EST

Next message: Andre Hedrick: "Re: Incorrect UDMA timing on VIA vt82c596b"
Previous message: Vojtech Pavlik: "Re: Incorrect UDMA timing on VIA vt82c596b"
In reply to: James Simmons: "[PATCH] drivers/usb/Config.in"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Oct 10, 2000 at 12:14:11AM -0700, James Simmons wrote:

> This patch fixes a minor config error for drivers/usb/Config.in. When you
> select USB Human Interface Device (HID) support I assume you should be
> able to select a USB mouse and/or USB keyboard. With the current Config.in
> you can't.
>
> --- Config.in.orig Tue Oct 10 00:10:06 2000
> +++ Config.in Tue Oct 10 00:10:27 2000
> @@ -80,7 +80,7 @@
> comment ' Input core support is needed for USB HID'
> else
> dep_tristate ' USB Human Interface Device (HID) support' CONFIG_USB_HID $CONFIG_USB $CONFIG_INPUT
> - if [ "$CONFIG_USB_HID" != "y" ]; then
> + if [ "$CONFIG_USB_HID" = "y" ]; then
> dep_tristate ' USB HIDBP Keyboard support' CONFIG_USB_KBD $CONFIG_USB $CONFIG_INPUT
> dep_tristate ' USB HIDBP Mouse support' CONFIG_USB_MOUSE $CONFIG_USB $CONFIG_INPUT
> fi

Config.in is correct as is. hid.c vs usbkbd.c+usbmouse.c are two
different ways to drive the same devices (Full HID vs. HIDBP). You can't
use both at once, hence the '!='.

-- 
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Andre Hedrick: "Re: Incorrect UDMA timing on VIA vt82c596b"
Previous message: Vojtech Pavlik: "Re: Incorrect UDMA timing on VIA vt82c596b"
In reply to: James Simmons: "[PATCH] drivers/usb/Config.in"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Oct 15 2000 - 21:00:14 EST