Re: __bad_udelay in 2.2.18pre15

From: Benjamin Herrenschmidt (bh40@calva.net)
Date: Wed Oct 11 2000 - 05:10:54 EST


>> 2.2.18pre15 defines udelay as (in file include/asm-i386/delay.h) :
>> extern void __bad_udelay(void);
>>
>> #define udelay(n) (__builtin_constant_p(n) ? \
>> ((n) > 20000 ? __bad_udelay() : __const_udelay((n) *
>> 0x10c6ul)) : \
>> __udelay(n))
>>
>> ...
>> It seems __bad_udelay is not defined anywhere in the kernel source.
>
>Correct. Its a compile time error trap

Well, at first, I wanted to implement it the same way on PPC. However, it
dies on all occurences where udelay is called with a non-constant expression.

I spotted this case in a few PPC specific stuffs (fixable), but also in
the sys_nanosleep code, and in the de4x5 driver.

Ben.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Oct 15 2000 - 21:00:17 EST