Re: BIG problem with BusLogic SCSI and/or something else

From: Richard B. Johnson (root@chaos.analogic.com)
Date: Thu Oct 12 2000 - 11:53:50 EST


On Thu, 12 Oct 2000, Jeff Garzik wrote:

> "Richard B. Johnson" wrote:
> > --- linux-2.2.17/drivers/scsi/BusLogic.h.orig Thu Oct 12 11:22:44 2000
> > +++ linux-2.2.17/drivers/scsi/BusLogic.h Thu Oct 12 11:47:07 2000
> > @@ -1509,6 +1509,7 @@
> > void BusLogic_AcquireHostAdapterLock(BusLogic_HostAdapter_T *HostAdapter,
> > ProcessorFlags_T *ProcessorFlags)
> > {
> > + spin_lock_irqsave(&BusLogic_lock, *ProcessorFlags);
> > }
> >
> >
> > @@ -1520,6 +1521,7 @@
> > void BusLogic_ReleaseHostAdapterLock(BusLogic_HostAdapter_T *HostAdapter,
> > ProcessorFlags_T *ProcessorFlags)
> > {
> > + spin_unlock_irqrestore(&BusLogic_lock, *ProcessorFlags);
> > }
>
>
> Don't pass processor flags on the stack...
>

Look at the @$%@)&$) code! I am NOT. The spin-lock code was in the
BusLogic code. It was defined as empty in-lines. It passed the address.
I just filled-in the stuff left out.

Cheers,
Dick Johnson

Penguin : Linux version 2.2.17 on an i686 machine (801.18 BogoMips).

"Memory is like gasoline. You use it up when you are running. Of
course you get it all back when you reboot..."; Actual explanation
obtained from the Micro$oft help desk.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sun Oct 15 2000 - 21:00:23 EST