Re: [PATCH] Make agpsupport work with modversions

From: David Woodhouse (dwmw2@infradead.org)
Date: Wed Oct 18 2000 - 13:23:54 EST

faith@valinux.com said:
> #ifdef CONFIG_MODULES

        /* use get_module_symbol() */

> #else

        /* reference agp_* directly */

> #endif

Don't you need to deal with the !CONFIG_AGP case correctly?

#ifdef CONFIG_MODULES
        /* blah */
#elif CONFIG_AGP
        /* blah */
        agp_available = 1;
#else
        agp_available = 0;
#endif

faith@valinux.com said:
> [Note that the other way to fix this would be to export
> get_module_symbol all the time, and have it just search the available
> symbol space if CONFIG_MODULES is 'n'.]

There is no available symbol space if CONFIG_MODULES is 'n'. 

--
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

This archive was generated by hypermail 2b29 : Mon Oct 23 2000 - 21:00:13 EST