On Thu, Oct 19, 2000 at 10:20:25PM +0200, Urban Widmark wrote:
> On Thu, 19 Oct 2000, Tom Rini wrote:
>
> > Hello all. The attached patch changes the behavoir of fs/nls/Config.in from:
> > CONFIG_SMB_FS != n to CONFIG_INET = y && CONFIG_SMB_FS != n. This is neeed
> > because if CONFIG_INET isn't set, CONFIG_SMB_FS isn't asked about and
> > therefor isn't set at all, so CONFIG_NLS is set to y. My only question about
> > this patch is if it shouldn't have depended on CONFIG_SMB_NLS_DEFAULT to start
> > with? (Maintainer CC'ed).
> It was supposed to be ok to not have a default nls value set but still be
> able to activate nls if you want to. Giving it the old no-nls behaviour
> until you say otherwise. Missing support from smbmount is the main reason
> for having the default.
Ah, ok.
> One solution might be to change the smbfs config to look more like the
> ncpfs config and force a 'n' value if CONFIG_INET isn't 'y'. Patch for
> this below, but the second patch you sent looks fine too. You didn't say
> which kernel version you are using ...
Sorry, this was on 2.4.0-test10-pre3, but I'm sure it applies to a good deal
of 2.4.0-testX.
> You could also try the cml2 config tool. The cml2 config language is much
> better at handling unset values and the current version has no problems
> with this (n is the same as undefined, as I understand it).
> http://www.tuxedo.org/~esr/kbuild
> (if you test it, kernel-rules.cml may need a search&replace of INTEGRATOR
> with ARCH_INTEGRATOR)
CML2 later, hopefully. :)
-- Tom Rini (TR1265) http://gate.crashing.org/~trini/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Mon Oct 23 2000 - 21:00:16 EST