Re: [PATCH] make my life easier ...

From: Linus Torvalds (torvalds@transmeta.com)
Date: Thu Oct 26 2000 - 10:31:34 EST


On Thu, 26 Oct 2000, Stephen Rothwell wrote:
>
> OK, I include below a more or less translation for 2.4. I have not even
> compiled this, and have not got the hardware to test it anyway.

I disagree violently with doing this in the low-level drivers.

If it cannot be done in user space (which is dubious in itself, but I'll
certainly accept it), then why not just do the equivalent of a reset in
the high-level IDE driver on coming back from sleep? Possibly together
with forcing any other setup state we know about.

That, together with using the pci_register_driver() thing, would be my
preferred approach by far. This kind of low-level twiddling and special
casing _will_ come back to haunt us later.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Tue Oct 31 2000 - 21:00:18 EST