Re: [PATCH] media/radio [check_region() removal... ]

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Thu Nov 09 2000 - 08:08:45 EST


Andrey Panin wrote:
> 1) how about drivers requesting 2 (or more) irq for one device ?
> AFAIK some PowerMac net drivers do it (bmac.c for example).

Should be fine.. If the driver distinguishes between the irqs, maybe
you should do "eth0-rx dma", "eth0-tx dma", etc.

> 2) i found that some net drivers (3c527.c, sk_mca.c) use io region and
> don't call request_region() at all. Should they be fixed ?

Probably... but there may be a reason for that, too.
drivers/net/atp.c, for example, does not use request_region because it
uses the standard parallel ports. (ideally, of course, it should use
the parport API...)

        Jeff

-- 
Jeff Garzik             |
Building 1024           | Would you like a Twinkie?
MandrakeSoft            |
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Nov 15 2000 - 21:00:14 EST