Re: [PATCH] Re: test11-pre5

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Tue Nov 14 2000 - 17:50:30 EST


Dan Aloni wrote:
>
> against: test11-pre5
> summery: dev_3c501.name shouldn't be NULL, or we get oops
> reason: Correct me if I'm wrong, but 3c501.c:init_module() calls
> net_init.c:register_netdev(&dev_3c501), which calls strchr(),
> {and might also,which might} dereference dev_3c501.name.

There is no dereferencing involved, and therefore no problem.

> struct net_device
> {
>
> /*
> * This is the first field of the "visible" part of this structure
> * (i.e. as seen by users in the "Space.c" file). It is the name
> * the interface.
> */
> char name[IFNAMSIZ];

-- 
Jeff Garzik             |
Building 1024           | The chief enemy of creativity is "good" sense
MandrakeSoft            |          -- Picasso
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Wed Nov 15 2000 - 21:00:27 EST