Re: hardcoded HZ in hub.c

From: Johannes Erdfelt (jerdfelt@valinux.com)
Date: Mon Nov 20 2000 - 15:17:46 EST


On Fri, Nov 17, 2000, Oleg Drokin <green@ixcelerator.com> wrote:
> hub.c in 2.4.0-test10 and above contains hardcoded HZ value,
> which is wrong. Here is the patch:
>
>
> --- drivers/usb/hub.c.orig Fri Nov 17 12:51:34 2000
> +++ drivers/usb/hub.c Fri Nov 17 12:51:59 2000
> @@ -813,7 +813,7 @@
> ret = kill_proc(khubd_pid, SIGTERM, 1);
> if (!ret) {
> /* Wait 10 seconds */
> - int count = 10 * 100;
> + int count = 10 * HZ;
>
> while (khubd_running && --count) {
> current->state = TASK_INTERRUPTIBLE;

We applied a slightly different patch which is would not remove the pages
out from under the thread, using semaphores instead.

This patch isn't needed anymore. Thanks anyway.

JE

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:19 EST