Re: [PATCH] Config.in fixes

• Next message: Johannes Erdfelt: "Re: hardcoded HZ in hub.c"
• Previous message: Maciej W. Rozycki: "Re: Strange lockup of the timer with 2.4.0-test10 SMP (and older)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

"Geert Uytterhoeven wrote:"
> --- linux-2.4.0-test11/drivers/video/Config.in Tue Sep 19 00:15:22 2000
> +++ geert-2.4.0-test11/drivers/video/Config.in Tue Nov 21 13:27:12 2000
> @@ -16,7 +16,7 @@
> if [ "$CONFIG_AMIGA" = "y" -o "$CONFIG_PCI" = "y" ]; then
> tristate ' Cirrus Logic support (EXPERIMENTAL)' CONFIG_FB_CLGEN
> tristate ' Permedia2 support (EXPERIMENTAL)' CONFIG_FB_PM2
> - if [ "$CONFIG_FB_PM2" = "y" ]; then
> + if [ "$CONFIG_FB_PM2" != "n" ]; then
> if [ "$CONFIG_PCI" = "y" ]; then
> bool ' enable FIFO disconnect feature' CONFIG_FB_PM2_FIFO_DISCONNECT
> bool ' generic Permedia2 PCI board support' CONFIG_FB_PM2_PCI

Please, be carefull with this type of fixes.
It is correct at the moment, but it would break xconfig if one changes

tristate ' Permedia2 support (EXPERIMENTAL)' CONFIG_FB_PM2

to

dep_tristate ' Permedia2 support (EXPERIMENTAL)' CONFIG_FB_PM2 $CONFIG_EXPERIMENTAL

It is safer to use [ "$CONFIG_FB_PM2" = "y" -o "$CONFIG_FB_PM2" = "m" ]
here.
   Andrzej

-- 
=======================================================================
  Andrzej M. Krzysztofowicz               ankry@mif.pg.gda.pl
  phone (48)(58) 347 14 61
Faculty of Applied Phys. & Math.,   Technical University of Gdansk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Johannes Erdfelt: "Re: hardcoded HZ in hub.c"
• Previous message: Maciej W. Rozycki: "Re: Strange lockup of the timer with 2.4.0-test10 SMP (and older)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:21 EST