Hi!
Just a few hints on __init/__exit stuff...
On Wed, 22 Nov 2000, Patrick van de Lageweg wrote:
> +struct reginit_item PHY_NTC_INIT[] = {
Can be marked __initdata
> +void undocumented_pci_fix (struct pci_dev *pdev)
Can be marked __init
> +void write_phy (struct fs_dev *dev, int regnum, int val)
Can be marked __init
> +int init_phy (struct fs_dev *dev, struct reginit_item *reginit)
Can be marked __init
> +void *aligned_kmalloc (int size, int flags, int alignment)
Can be marked __init
> +int init_q (struct fs_dev *dev,
> + struct queue *txq, int queue, int nentries, int is_rq)
Can be marked __init
> +int init_fp (struct fs_dev *dev,
> + struct freepool *fp, int queue, int bufsize, int nr_buffers)
Can be marked __init
> +void free_queue (struct fs_dev *dev, struct queue *txq)
Can be marked __exit
> +void free_freepool (struct fs_dev *dev, struct freepool *fp)
Can be marked __exit
You may also consider processing firestream.[ch] through indent because
spacing is inconsistent - sometimes tabs, sometimes 8*space (it would
be nice too have tabs everywhere).
Regards
-- Bartlomiej Zolnierkiewicz <bkz@linux-ide.org>- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Nov 23 2000 - 21:00:26 EST