diff -urN /mnt/disk/linux/drivers/net/3c503.c /linux/drivers/net/3c503.c --- /mnt/disk/linux/drivers/net/3c503.c Thu Nov 16 22:57:16 2000 +++ /linux/drivers/net/3c503.c Sun Nov 19 23:03:21 2000 @@ -150,7 +150,7 @@ if (inb(ioaddr + 0x408) == 0xff) { mdelay(1); retval = -ENODEV; - goto out; + goto err_out; } /* We verify that it's a 3C503 board by checking the first three octets @@ -161,7 +161,7 @@ if ( (iobase_reg & (iobase_reg - 1)) || (membase_reg & (membase_reg - 1))) { retval = -ENODEV; - goto out; + goto err_out; } saved_406 = inb_p(ioaddr + 0x406); outb_p(ECNTRL_RESET|ECNTRL_THIN, ioaddr + 0x406); /* Reset it... */ @@ -174,21 +174,21 @@ /* Restore the register we frobbed. */ outb(saved_406, ioaddr + 0x406); retval = -ENODEV; - goto out; + goto err_out; } if (ei_debug && version_printed++ == 0) - printk(version); + printk(KERN_INFO "%s", version); dev->base_addr = ioaddr; /* Allocate dev->priv and fill in 8390 specific dev fields. */ if (ethdev_init(dev)) { - printk ("3c503: unable to allocate memory for dev->priv.\n"); + printk (KERN_ERR "3c503: unable to allocate memory for dev->priv.\n"); retval = -ENOMEM; - goto out; + goto err_out; } - printk("%s: 3c503 at i/o base %#3x, node ", dev->name, ioaddr); + printk(KERN_INFO "%s: 3c503 at i/o base %#3x, node ", dev->name, ioaddr); /* Retrieve and print the ethernet address. */ for (i = 0; i < 6; i++) @@ -239,7 +239,7 @@ isa_writel(test_val, mem_base + i); if (isa_readl(mem_base) != 0xba5eba5e || isa_readl(mem_base + i) != test_val) { - printk("3c503: memory failure or memory address conflict.\n"); + printk(KERN_ERR "3c503: memory failure or memory address conflict.\n"); dev->mem_start = 0; ei_status.name = "3c503-PIO"; break; @@ -288,7 +288,7 @@ if (dev->irq == 2) dev->irq = 9; else if (dev->irq > 5 && dev->irq != 9) { - printk("3c503: configured interrupt %d invalid, will use autoIRQ.\n", + printk(KERN_WARNING "3c503: configured interrupt %d invalid, will use autoIRQ.\n", dev->irq); dev->irq = 0; } @@ -299,7 +299,7 @@ dev->stop = &el2_close; if (dev->mem_start) - printk("%s: %s - %dkB RAM, 8kB shared mem window at %#6lx-%#6lx.\n", + printk( KERN_INFO "%s: %s - %dkB RAM, 8kB shared mem window at %#6lx-%#6lx.\n", dev->name, ei_status.name, (wordlength+1)<<3, dev->mem_start, dev->mem_end-1); @@ -307,11 +307,12 @@ { ei_status.tx_start_page = EL2_MB1_START_PG; ei_status.rx_start_page = EL2_MB1_START_PG + TX_PAGES; - printk("\n%s: %s, %dkB RAM, using programmed I/O (REJUMPER for SHARED MEMORY).\n", - dev->name, ei_status.name, (wordlength+1)<<3); + printk( KERN_ERR "\n%s: %s, %dkB RAM, using programmed I/O (REJUMPER for SHARED MEMORY).\n", + dev->name, ei_status.name, (wordlength+1)<<3); } return 0; -out: + +err_out: release_region(ioaddr, EL2_IO_EXTENT); return retval; } @@ -319,6 +320,7 @@ static int el2_open(struct net_device *dev) { + int retval; if (dev->irq < 2) { int irqlist[] = {5, 9, 3, 4, 0}; @@ -332,7 +334,7 @@ outb_p(0x04 << ((*irqp == 9) ? 2 : *irqp), E33G_IDCFR); outb_p(0x00, E33G_IDCFR); if (*irqp == probe_irq_off(cookie) /* It's a good IRQ line! */ - && request_irq (dev->irq = *irqp, ei_interrupt, 0, ei_status.name, dev) == 0) + && request_irq (dev->irq = *irqp, ei_interrupt, 0, dev->name, dev) == 0) break; } } while (*++irqp); @@ -341,8 +343,8 @@ return -EAGAIN; } } else { - if (request_irq(dev->irq, ei_interrupt, 0, ei_status.name, dev)) { - return -EAGAIN; + if ((retval = request_irq(dev->irq, ei_interrupt, 0, dev->name, dev))) { + return retval; } } @@ -370,7 +372,7 @@ el2_reset_8390(struct net_device *dev) { if (ei_debug > 1) { - printk("%s: Resetting the 3c503 board...", dev->name); + printk(KERN_DEBUG "%s: Resetting the 3c503 board...", dev->name); printk("%#lx=%#02x %#lx=%#02x %#lx=%#02x...", E33G_IDCFR, inb(E33G_IDCFR), E33G_CNTRL, inb(E33G_CNTRL), E33G_GACFR, inb(E33G_GACFR)); } @@ -464,7 +466,7 @@ { if(!boguscount--) { - printk("%s: FIFO blocked in el2_block_output.\n", dev->name); + printk(KERN_WARNING "%s: FIFO blocked in el2_block_output.\n", dev->name); el2_reset_8390(dev); goto blocked; } @@ -514,7 +516,7 @@ { if(!boguscount--) { - printk("%s: FIFO blocked in el2_get_8390_hdr.\n", dev->name); + printk(KERN_WARNING "%s: FIFO blocked in el2_get_8390_hdr.\n", dev->name); memset(hdr, 0x00, sizeof(struct e8390_pkt_hdr)); el2_reset_8390(dev); goto blocked; @@ -580,7 +582,7 @@ { if(!boguscount--) { - printk("%s: FIFO blocked in el2_block_input.\n", dev->name); + printk(KERN_WARNING "%s: FIFO blocked in el2_block_input.\n", dev->name); el2_reset_8390(dev); goto blocked; }