Re: [PATCH] removal of "static foo = 0" from drivers/ide (test11)

From: Vojtech Pavlik (vojtech@suse.cz)
Date: Fri Nov 24 2000 - 16:40:18 EST


On Thu, Nov 23, 2000 at 10:01:53PM +1100, Rusty Russell wrote:
> In message <Pine.LNX.4.21.0011212300590.950-100000@penguin.homenet> you write:
> > > On Tue, 21 Nov 2000 22:25:01 Bartlomiej Zolnierkiewicz wrote:
> > > >
> > > > Quick removal of unnecessary initialization to 0.
> >
> > Quite the contrary. The patch seems correct and useful to me. What do you
> > think is wrong with it? (Linus accepted megabytes worth of the above in
> > the past...)
>
> What irritates about these monkey-see-monkey-do patches is that if I
> initialize a variable to NULL, it's because my code actually relies on
> it; I don't want that information eliminated.

Yes, but if it generates a bigger (== worse) binary?

-- 
Vojtech Pavlik
SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 30 2000 - 21:00:12 EST