Re: [PATCH]: 2.4.0-testx: USB Audio

From: Pavel Machek (pavel@suse.cz)
Date: Mon Nov 27 2000 - 18:04:56 EST

Next message: Tigran Aivazian: "Re: [PATCH] no RLIMIT_NPROC for root, please"
Previous message: Pavel Rabel: "[PATCH] mad16 old OSS config"
In reply to: Thomas Sailer: "[PATCH]: 2.4.0-testx: USB Audio"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

HI!

> This patch adds a workaround for the Dallas chip; the chip tags
> its 8bit formats with PCM8 but expects signed data.

> @@ -2895,6 +2897,9 @@
> continue;
> }
> format = (fmt[5] == 2) ? (AFMT_U16_LE | AFMT_U8) : (AFMT_S16_LE | AFMT_S8);
> + /* Dallas DS4201 workaround */
> + if (dev->descriptor.idVendor == 0x04fa && dev->descriptor.idProduct == 0x4201)
> + format = (AFMT_S16_LE | AFMT_S8);

Should not you printk() in case of buggy hardware?
Pavel

-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Tigran Aivazian: "Re: [PATCH] no RLIMIT_NPROC for root, please"
Previous message: Pavel Rabel: "[PATCH] mad16 old OSS config"
In reply to: Thomas Sailer: "[PATCH]: 2.4.0-testx: USB Audio"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Nov 30 2000 - 21:00:20 EST