Re: TCP push missing with writev()

From: Andi Kleen (ak@suse.de)
Date: Thu Nov 30 2000 - 13:14:14 EST


On Thu, Nov 30, 2000 at 05:35:41PM +0000, Ben Mansell wrote:
> (possibly treading on ground covered before:
> http://www.uwsg.iu.edu/hypermail/linux/kernel/9904.1/0304.html )
>
> To be brief and to the point: Should there be any difference between the
> following two ways of writing data to a TCP socket?
>
> 1) write( fd, buffer, length )
> 2) writev( fd, {buffer, length}, {NULL,0} )

No.

>
> The problem is that if data happens to be written via method (2), then
> the PUSH flag is never set on any packets generated. This is a bug,
> surely?

I just tried it on 2.2.17 and 2.4.0test11 and it sets PUSH for writev()
for both cases just fine. Maybe you could supply a test program and tcpdump
logs for what you think is wrong ?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Thu Nov 30 2000 - 21:00:25 EST