Re: [PATCH] ipchains log will show all flags

From: Rusty Russell (rusty@linuxcare.com.au)
Date: Tue Dec 05 2000 - 08:55:09 EST

Next message: Matt_Domsch@Dell.com: "[PATCH] pci_read_bases trivial fixup"
Previous message: Gerhard Esterhuizen: "Machine Check Exception - bluesmoke.c dump in 2.2.17"
In reply to: Christian W. Zuckschwerdt: "[PATCH] ipchains log will show all flags"
Next in thread: Mike A. Harris: "Re: [PATCH] ipchains log will show all flags"
Reply: Mike A. Harris: "Re: [PATCH] ipchains log will show all flags"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

In message <0012051408110.1526-100000@localhost> you write:
> Hi Linus,
>
> This tiny patch extends ipchains logging. This way one can distinguish
> (plain) connection attempts and (Xmas, Fin,...) scans. E.g.
> kernel: Packet log: input - lo PROTO=6 127.0.0.1:40326 127.0.0.1:80
> L=40 S=0x00 I=5808 F=0x0000 T=51 (#1)
> vs.
> L=40 S=0x00 I=5808 F=0x0000 T=51 (#1) B=-s--a-
> and
> L=40 S=0x00 I=5808 F=0x0000 T=51 (#1) B=fs-p-u
>
> Please comment on the format (B=...) and implementation details (speed).
> The patch is against 2.2.17's /net/ipv4/ip_fw.c

Looks OK, but CC'ing the maintainer is simple politeness.

> + if (ip->protocol == IPPROTO_TCP)

You probably want to insert `&& !(ip->frag_off & htons(IP_OFFSET))'

> + tcp-syn ? 's' : '-', tcp->rst ? 'r' : '-',

You mean `tcp->syn' not `tcp-syn'.

I like the fact that it doesn't disturb the format, simply appends,
and it has been a not-uncommon request.

But application is up to Alan Cox, who ruleth the 2.2 series.

Rusty.

--
Hacking time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Matt_Domsch@Dell.com: "[PATCH] pci_read_bases trivial fixup"
Previous message: Gerhard Esterhuizen: "Machine Check Exception - bluesmoke.c dump in 2.2.17"
In reply to: Christian W. Zuckschwerdt: "[PATCH] ipchains log will show all flags"
Next in thread: Mike A. Harris: "Re: [PATCH] ipchains log will show all flags"
Reply: Mike A. Harris: "Re: [PATCH] ipchains log will show all flags"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu Dec 07 2000 - 21:00:13 EST