Re: [PATCH] mdacon.c cleanup

From: David Woodhouse (dwmw2@infradead.org)
Date: Tue Dec 12 2000 - 04:15:11 EST

Next message: David S. Miller: "Re: pdev_enable_device no longer used ?"
Previous message: Paul C. Nendick : "Re: 2.2.16 SMP: mtrr errors"
In reply to: Pavel Rabel: "[PATCH] mdacon.c cleanup"
Next in thread: Pavel Rabel: "Re: [PATCH] mdacon.c cleanup"
Reply: Pavel Rabel: "Re: [PATCH] mdacon.c cleanup"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

pavel@web.sajt.cz said:
> Both MODULE_PARM and __init are removed by precompiler when not
> compiler as module, so no need for ifdefs. 2.4.0-test12pre8

-#ifdef MODULE_PARM
MODULE_PARM(mda_first_vc, "1-255i");
MODULE_PARM(mda_last_vc, "1-255i");
-#endif

That was #ifdef MODULE_PARM not #ifdef MODULE. Probably there for
compatibility with older kernels. Although I'm not sure it's even required
in 2.2.

And you seem to have forgotten to Cc the maintainer.

-- dwmw2

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/

Next message: David S. Miller: "Re: pdev_enable_device no longer used ?"
Previous message: Paul C. Nendick : "Re: 2.2.16 SMP: mtrr errors"
In reply to: Pavel Rabel: "[PATCH] mdacon.c cleanup"
Next in thread: Pavel Rabel: "Re: [PATCH] mdacon.c cleanup"
Reply: Pavel Rabel: "Re: [PATCH] mdacon.c cleanup"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Dec 15 2000 - 21:00:25 EST