Q: natsemi.c spinlocks

From: Manfred (manfred@colorfullife.com)
Date: Sat Dec 23 2000 - 12:45:52 EST

Next message: Peter De Schrijver: "2.4.0-test12 on Miata"
Previous message: Mike Galbraith: "Re: Fatal Oops on boot with 2.4.0testX and recent GCC snapshots"
Next in thread: Andrew Morton: "Re: Q: natsemi.c spinlocks"
Reply: Andrew Morton: "Re: Q: natsemi.c spinlocks"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Jeff, Tjeerd,

I spotted the spin_lock in natsemi.c, and I think it's bogus.

The "simultaneous interrupt entry" is a bug in some 2.0 and 2.1 kernel
(even Alan didn't remember it exactly when I asked him), thus a sane
driver can assume that an interrupt handler is never reentered.

Donald often uses dev->interrupt to hide other races, but I don't see
anything in this driver (tx_timeout and netdev_timer are both trivial)

--
  Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Next message: Peter De Schrijver: "2.4.0-test12 on Miata"
Previous message: Mike Galbraith: "Re: Fatal Oops on boot with 2.4.0testX and recent GCC snapshots"
Next in thread: Andrew Morton: "Re: Q: natsemi.c spinlocks"
Reply: Andrew Morton: "Re: Q: natsemi.c spinlocks"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat Dec 23 2000 - 21:00:34 EST