Re: [PATCH] de620.c: nitpicking

• Next message: Arnaldo Carvalho de Melo: "[PATCH] tidy 53c7,8xx.c was Re: [PATCH] de620.c: nitpicking"
• Previous message: Andrea Arcangeli: "Re: `rmdir .` doesn't work in 2.4"
• In reply to: Arnaldo Carvalho de Melo: "[PATCH] de620.c: nitpicking"
• Next in thread: Arnaldo Carvalho de Melo: "[PATCH] tidy 53c7,8xx.c was Re: [PATCH] de620.c: nitpicking"
• Reply: Arnaldo Carvalho de Melo: "[PATCH] tidy 53c7,8xx.c was Re: [PATCH] de620.c: nitpicking"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi,

        Please consider applying, no need to restore_flags here, as it is
restored in the beginning of this if block.

- Arnaldo

--- linux-2.4.0-ac3/drivers/scsi/53c7,8xx.c Fri Oct 13 18:40:51 2000
+++ linux-2.4.0-ac3.acme/drivers/scsi/53c7,8xx.c Mon Jan 8 20:24:35 2001
@@ -1899,7 +1899,6 @@
                 hostdata->script, start);
             printk ("scsi%d : DSPS = 0x%x\n", host->host_no,
                 NCR53c7x0_read32(DSPS_REG));
- restore_flags(flags);
             return -1;
         }
             hostdata->test_running = 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Arnaldo Carvalho de Melo: "[PATCH] tidy 53c7,8xx.c was Re: [PATCH] de620.c: nitpicking"
• Previous message: Andrea Arcangeli: "Re: `rmdir .` doesn't work in 2.4"
• In reply to: Arnaldo Carvalho de Melo: "[PATCH] de620.c: nitpicking"
• Next in thread: Arnaldo Carvalho de Melo: "[PATCH] tidy 53c7,8xx.c was Re: [PATCH] de620.c: nitpicking"
• Reply: Arnaldo Carvalho de Melo: "[PATCH] tidy 53c7,8xx.c was Re: [PATCH] de620.c: nitpicking"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jan 15 2001 - 21:00:20 EST